[PATCH] rcu: fix build failure with debug dp log level

Stephen Hemminger stephen at networkplumber.org
Thu Sep 29 00:21:21 CEST 2022


On Mon, 29 Aug 2022 22:21:51 +0530
Anoob Joseph <anoobj at marvell.com> wrote:

> Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the
> same by including the required header when RTE_LOG_DP_LEVEL is
> set to RTE_LOG_DEBUG.
> 
> ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’
>   678 |    "%s: status: least acked token = %" PRIu64,
>       |                                        ^~~~~~
> 
> Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
> Cc: sean.morrissey at intel.com
> 
> Signed-off-by: Anoob Joseph <anoobj at marvell.com>
> ---
>  lib/rcu/rte_rcu_qsbr.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h
> index d81bf5e8db..b0f1720ca1 100644
> --- a/lib/rcu/rte_rcu_qsbr.h
> +++ b/lib/rcu/rte_rcu_qsbr.h
> @@ -37,6 +37,10 @@ extern "C" {
>  #include <rte_atomic.h>
>  #include <rte_ring.h>
> 
> +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> +#include <inttypes.h>
> +#endif
> +
>  extern int rt

This is not the best way to fix this.
Just always include the header file.
Having it conditional can lead to more problems


More information about the dev mailing list