[PATCH v7 0/3] add uncore api to be called through l3fwd-power

Hunt, David david.hunt at intel.com
Thu Sep 29 15:27:33 CEST 2022


Hi Tadhg,

On 28/09/2022 14:30, Tadhg Kearney wrote:
> This is targeting 22.11 and aims to add an API to DPDK power library to allow
> uncore frequency adjustment. This will be called through the l3fwd-power app
> and gives the ability to set the minimum and maximum uncore frequency to both min,
> max or specific frequency index.
>
> Signed-off-by: tadhgkearney <tadhg.kearney at intel.com>
> Reviewed-by: David Hunt <david.hunt at intel.com>
> ---
>
> v2:
> Fix compilation warnings and errors.
> v3:
> Remove addition of x86 global macros.
> Add 2 new API's for getting package and die numbers from system.
> Address comments from mailing list.
> Improve efficiency of code and code quality.
> v4:
> Fix compilation warnings and errors.
> v5:
> Improve error message for uncore access not working.
> v6:
> Fix uncore exit being called if uncore option not selected.
> v7:
> Address ml comments.
>
>
> Tadhg Kearney (3):
>    power: add uncore frequency control API to the power library
>    l3fwd-power: add option to call uncore API
>    test/power: add unit tests for uncore API
>
>   app/test/meson.build                          |   2 +
>   app/test/test_power_uncore.c                  | 301 ++++++++++++
>   doc/guides/prog_guide/power_man.rst           |  38 ++
>   doc/guides/rel_notes/release_22_11.rst        |   5 +
>   .../sample_app_ug/l3_forward_power_man.rst    |  29 ++
>   examples/l3fwd-power/main.c                   | 126 ++++-
>   lib/power/meson.build                         |   2 +
>   lib/power/rte_power_uncore.c                  | 451 ++++++++++++++++++
>   lib/power/rte_power_uncore.h                  | 194 ++++++++
>   lib/power/version.map                         |  11 +
>   10 files changed, 1157 insertions(+), 2 deletions(-)
>   create mode 100644 app/test/test_power_uncore.c
>   create mode 100644 lib/power/rte_power_uncore.c
>   create mode 100644 lib/power/rte_power_uncore.h


Latest revision looks good to me. Consider the series:

Acked-by: David Hunt <david.hunt at intel.com>




More information about the dev mailing list