[PATCH v3 10/11] telemetry: disable json print formatting with msvc
Tyler Retzlaff
roretzla at linux.microsoft.com
Thu Apr 6 17:45:20 CEST 2023
On Thu, Apr 06, 2023 at 10:25:07AM +0100, Bruce Richardson wrote:
> On Wed, Apr 05, 2023 at 05:45:18PM -0700, Tyler Retzlaff wrote:
> > VLAs are unsafe and will never be implemented in MSVC. When compiling
> > with MSVC just return immediately indicating 0 output characters
> > formatted.
> >
> > For now telemetry doesn't work on Windows, we will revisit support for
> > the telemetry library sometime after we establish the DPDK unit tests.
> >
> > Signed-off-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
> > ---
> > lib/telemetry/telemetry_json.h | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> I'm guessing this patch can be dropped if patchset [1] is merged, right?
Absolutely. I'll take a look at the referenced series soon.
>
> /Bruce
>
> [1] http://patches.dpdk.org/project/dpdk/list/?series=27629
More information about the dev
mailing list