[PATCH v2 5/6] bus: enable cdx bus
Gupta, Nipun
Nipun.Gupta at amd.com
Sun Apr 16 11:21:39 CEST 2023
> -----Original Message-----
> From: Yigit, Ferruh <Ferruh.Yigit at amd.com>
> Sent: Friday, April 14, 2023 10:16 PM
> To: Gupta, Nipun <Nipun.Gupta at amd.com>; dev at dpdk.org;
> thomas at monjalon.net; david.marchand at redhat.com
> Cc: Anand, Harpreet <harpreet.anand at amd.com>; Agarwal, Nikhil
> <nikhil.agarwal at amd.com>
> Subject: Re: [PATCH v2 5/6] bus: enable cdx bus
>
> On 4/13/2023 2:27 PM, Nipun Gupta wrote:
> > enable the compilation of cdx bus
> >
> > Signed-off-by: Nipun Gupta <nipun.gupta at amd.com>
> > ---
> > drivers/bus/meson.build | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build
> > index 6d2520c543..a78b4283bf 100644
> > --- a/drivers/bus/meson.build
> > +++ b/drivers/bus/meson.build
> > @@ -3,6 +3,7 @@
> >
> > drivers = [
> > 'auxiliary',
> > + 'cdx',
> > 'dpaa',
> > 'fslmc',
> > 'ifpga',
>
> Why not squash this to the first patch?
>
> I think better to enable bus with the first patch and gradually expand
> the feature, this way each patch is checked that it builds fine.
>
> There are cases some interim patches can't be built successfully, which
> may required enabling after a few patches, but I think this is not the case.
Sure, I will merge into the first patch. Compilation should be working there too.
Thanks,
Nipun
More information about the dev
mailing list