[PATCH v2 3/3] net/iavf: support Rx timestamp offload on SSE

[Zeng, ZhichaoX]

Hi David,

> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Wednesday, April 26, 2023 11:32 PM
> To: Zeng, ZhichaoX <zhichaox.zeng at intel.com>
> Cc: dev at dpdk.org; Zhang, Qi Z <qi.z.zhang at intel.com>; Tang, Yaqi
> <yaqi.tang at intel.com>; Han, YingyaX <yingyax.han at intel.com>; Richardson,
> Bruce <bruce.richardson at intel.com>; Konstantin Ananyev
> <konstantin.v.ananyev at yandex.ru>; Wu, Jingjing <jingjing.wu at intel.com>;
> Xing, Beilei <beilei.xing at intel.com>
> Subject: Re: [PATCH v2 3/3] net/iavf: support Rx timestamp offload on SSE
> 
> On Wed, Apr 12, 2023 at 10:42 AM Zhichao Zeng <zhichaox.zeng at intel.com>
> wrote:
> [snip]
> > +#ifndef RTE_LIBRTE_IAVF_16BYTE_RX_DESC #pragma GCC diagnostic
> push
> > +#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
> > +               if (rxq->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP) {
> > +                       inflection_point = (inflection_point <= var) ? inflection_point :
> 0;
> > +                       switch (inflection_point) {
> > +                       case 1:
> > +                               *RTE_MBUF_DYNFIELD(rx_pkts[pos + 0],
> > +                                       iavf_timestamp_dynfield_offset + 4, uint32_t *) += 1;
> > +                       case 2:
> > +                               *RTE_MBUF_DYNFIELD(rx_pkts[pos + 1],
> > +                                       iavf_timestamp_dynfield_offset + 4, uint32_t *) += 1;
> > +                       case 3:
> > +                               *RTE_MBUF_DYNFIELD(rx_pkts[pos + 2],
> > +                                       iavf_timestamp_dynfield_offset + 4, uint32_t *) += 1;
> > +                       case 4:
> > +                               *RTE_MBUF_DYNFIELD(rx_pkts[pos + 3],
> > +                                       iavf_timestamp_dynfield_offset + 4, uint32_t *) += 1;
> > +                               rxq->phc_time += (uint64_t)1 << 32;
> > +                       case 0:
> > +                               break;
> > +                       default:
> > +                               printf("invalid inflection point for
> > +rx timestamp\n");
> 
> No printf.
> For all 3 patches of this series, please replace with this driver dedicated
> macro for debug logging.

Thanks for your comments, I will replace them in the next version.
> 
> --
> David Marchand