Dpaa2 driver using system("echo...")

Sachin Saxena (OSS) sachin.saxena at oss.nxp.com
Fri Apr 28 12:12:29 CEST 2023


On 4/10/2023 9:51 PM, Stephen Hemminger wrote:
> When the CodeQl (https://codeql.github.com/) is run against DPDK,
> one of the issues it reports is the unsafe usage of system() in code.
> 
> I reported and fixed one of these issues in the dpaa2 driver
> https://patchwork.dpdk.org/project/dpdk/patch/20220602214957.150071-1-stephen@networkplumber.org/
> but it seems to have been ignored.
> 
> Could one of the maintainers of that driver review it?
> 

Hello Stephen,
Apology for the delay and thanks for the changes suggested for dpaa2 
driver improvement.

I have reviewed your changes and logically they look fine. When testing, 
found issue of memory corruption that I have fixed over your changes. I 
will send a 'v2' patch in context of your previous patch including this 
fix for dpaa2 platform.

-- 
Thanks,
Sachin Saxena
(NXP)



More information about the dev mailing list