[RFC PATCH 3/3] ethdev: rename parameter in API to get FEC

Denis Pryazhennikov denis.pryazhennikov at arknetworks.am
Fri Apr 28 12:27:28 CEST 2023


Only one valid FEC mode can be get by rte_eth_fec_get().
The previous name implied that more than one FEC mode
can be obtained.
Documentation was updated accordingly.

Signed-off-by: Denis Pryazhennikov <denis.pryazhennikov at arknetworks.am>
Acked-by: Ivan Malov <ivan.malov at arknetworks.am>
Acked-by: Viacheslav Galaktionov <viacheslav.galaktionov at arknetworks.am>
---
 lib/ethdev/rte_ethdev.c | 8 ++++----
 lib/ethdev/rte_ethdev.h | 9 +++------
 2 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index d02ee161cf6d..b046d4ea2f06 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -4718,7 +4718,7 @@ rte_eth_fec_get_capability(uint16_t port_id,
 }
 
 int
-rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa)
+rte_eth_fec_get(uint16_t port_id, uint32_t *fec_mode)
 {
 	struct rte_eth_dev *dev;
 	int ret;
@@ -4726,7 +4726,7 @@ rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa)
 	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 	dev = &rte_eth_devices[port_id];
 
-	if (fec_capa == NULL) {
+	if (fec_mode == NULL) {
 		RTE_ETHDEV_LOG(ERR,
 			"Cannot get ethdev port %u current FEC mode to NULL\n",
 			port_id);
@@ -4735,9 +4735,9 @@ rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa)
 
 	if (*dev->dev_ops->fec_get == NULL)
 		return -ENOTSUP;
-	ret = eth_err(port_id, (*dev->dev_ops->fec_get)(dev, fec_capa));
+	ret = eth_err(port_id, (*dev->dev_ops->fec_get)(dev, fec_mode));
 
-	rte_eth_trace_fec_get(port_id, fec_capa, ret);
+	rte_eth_trace_fec_get(port_id, fec_mode, ret);
 
 	return ret;
 }
diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 0f10ac944061..aa71dbafc01f 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -4203,11 +4203,8 @@ int rte_eth_fec_get_capability(uint16_t port_id,
  *
  * @param port_id
  *   The port identifier of the Ethernet device.
- * @param fec_capa
- *   A bitmask of enabled FEC modes. If AUTO bit is set, other
- *   bits specify FEC modes which may be negotiated. If AUTO
- *   bit is clear, specify FEC modes to be used (only one valid
- *   mode per speed may be set).
+ * @param fec_mode
+ *   The current FEC mode.
  * @return
  *   - (0) if successful.
  *   - (-ENOTSUP) if underlying hardware OR driver doesn't support.
@@ -4216,7 +4213,7 @@ int rte_eth_fec_get_capability(uint16_t port_id,
  *   - (-ENODEV)  if *port_id* invalid.
  */
 __rte_experimental
-int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa);
+int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_mode);
 
 /**
  * @warning
-- 
2.37.0 (Apple Git-136)



More information about the dev mailing list