[PATCH] build: check drivers class dependencies early
Morten Brørup
mb at smartsharesystems.com
Tue Aug 1 12:49:24 CEST 2023
> From: David Marchand [mailto:david.marchand at redhat.com]
> Sent: Tuesday, 1 August 2023 12.21
>
> On Tue, Aug 1, 2023 at 11:25 AM Bruce Richardson
> <bruce.richardson at intel.com> wrote:
> >
> > On Tue, Aug 01, 2023 at 10:52:53AM +0200, David Marchand wrote:
> > > Drivers implementing a class of devices (for example, drivers/event)
> > > depend on the associated abstraction library (lib/eventdev).
> > > This dependency is expressed in the top level meson.build for this class
> > > (drivers/event/meson.build).
> > >
> > > As we are making more libraries optional, custom constructs referencing
> > > the class dependencies in some drivers meson.build (event/dlb2) may break.
> > >
> > > It would be possible to add more checks in those drivers meson.build but
> > > it is more straightforward to not even consider a driver meson.build when
> > > the class dependencies are not met.
> > >
> > > Signed-off-by: David Marchand <david.marchand at redhat.com>
> > > ---
>
> This gives the following output (testing on top of your series
> extending optional libs and a fix on the new reasm perf test).
> https://github.com/david-
> marchand/dpdk/actions/runs/5725429526/job/15513923381#step:19:346
>
> ...
> =================
> Content Skipped
> =================
> ...
> drivers:
> ...
> mempool/dpaa2: not in enabled drivers build config
> mempool/octeontx: not in enabled drivers build config
> mempool/stack: not in enabled drivers build config
> dma/*: missing internal dependency, "dmadev"
> net/af_packet: not in enabled drivers build config
> net/af_xdp: not in enabled drivers build config
> net/ark: not in enabled drivers build config
> ...
>
For the concept suggested by David (and preferably with Bruce's output):
Acked-by: Morten Brørup <mb at smartsharesystems.com>
More information about the dev
mailing list