[PATCH v5 02/10] app/test: tag tests with the test type
Bruce Richardson
bruce.richardson at intel.com
Wed Aug 16 17:05:34 CEST 2023
On Wed, Aug 16, 2023 at 04:56:23PM +0200, David Marchand wrote:
> On Tue, Aug 15, 2023 at 5:23 PM Bruce Richardson
> <bruce.richardson at intel.com> wrote:
> > diff --git a/app/test/test_acl.c b/app/test/test_acl.c
> > index 623f34682e..bf1466fe11 100644
> > --- a/app/test/test_acl.c
> > +++ b/app/test/test_acl.c
> > @@ -1749,4 +1749,4 @@ test_acl(void)
> >
> > #endif /* !RTE_EXEC_ENV_WINDOWS */
> >
> > -REGISTER_TEST_COMMAND(acl_autotest, test_acl);
> > +REGISTER_FAST_TEST(acl_autotest, True, True, test_acl);
>
> A bit surprising to read "True" and not "true" in some C code.
> I see meson supports both forms.
> Do you have a reason to go with "True"?
> Maybe you prefer to keep it like this so it is not confused with the C
> boolean keyword?
>
This info is pulled out by python script, so I believe it is capitalized so
I can process them as boolean values there.
However, looking at the script, it doesn't actually ever convert to boolean
right now, so this may be a holdover from earlier versions. When we pass
the values to meson, they are all forced to lowercase.
/Bruce
More information about the dev
mailing list