[PATCH v3 1/6] eal: provide rte stdatomics optional atomics API

[Tyler Retzlaff]

On Wed, Aug 16, 2023 at 02:04:06PM -0700, Tyler Retzlaff wrote:
> On Wed, Aug 16, 2023 at 10:55:51PM +0200, Morten Brørup wrote:
> > > From: Tyler Retzlaff [mailto:roretzla at linux.microsoft.com]
> > > Sent: Wednesday, 16 August 2023 21.19
> > > 
> > > Provide API for atomic operations in the rte namespace that may
> > > optionally be configured to use C11 atomics with meson
> > > option enable_stdatomics=true
> > > 
> > > Signed-off-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
> > > Reviewed-by: Morten Brørup <mb at smartsharesystems.com>
> > > ---
> > 
> > "#define RTE_ATOMIC(type) [...]" is missing in lib/eal/include/rte_stdatomic.h, both with and without RTE_ENABLE_STDATOMIC.
> > 
> > I suggest you keep it together with "#define __rte_atomic [...]".
> 
> this seems to be an error i made in patch submission, somehow i managed
> to drop the changes i made from v2-v3 from the series i submitted i'm
> confused how i managed to fat finger it.

okay! i know what i did. somehow the additions of the macros were
placed into patch 2 instead of patch 1 where they belong. i'm glad
there's a simple explanation :)

v4 coming up with the it moved into the patch it belongs in.

> 
> i'll submit a new series with the correct changes to rte_stdatomic.h
> > 
> > Please also add descriptions as comments to both (type-qualifier and -specifier) in both locations. Your descriptions from the mailing list discussion are fine.
> > 
> 
> i'll do this in the v4 commit message
> 
> thanks