[PATCH v2] eventdev/eth_rx: add new adapter create API

[Naga Harish K, S V]

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk at gmail.com>
> Sent: Thursday, August 17, 2023 2:27 PM
> To: Naga Harish K, S V <s.v.naga.harish.k at intel.com>
> Cc: dev at dpdk.org; Jayatheerthan, Jay <jay.jayatheerthan at intel.com>;
> Carrillo, Erik G <erik.g.carrillo at intel.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar at intel.com>; McDaniel, Timothy
> <timothy.mcdaniel at intel.com>; Pavan Nikhilesh
> <pbhagavatula at marvell.com>; Shijith Thotton <sthotton at marvell.com>;
> Hemant Agrawal <hemant.agrawal at nxp.com>; Sachin Saxena
> <sachin.saxena at oss.nxp.com>; Van Haaren, Harry
> <harry.van.haaren at intel.com>; mattias.ronnblom
> <mattias.ronnblom at ericsson.com>; Liang Ma <liangma at liangbit.com>;
> Mccarthy, Peter <peter.mccarthy at intel.com>
> Subject: Re: [PATCH v2] eventdev/eth_rx: add new adapter create API
> 
> On Thu, Aug 17, 2023 at 11:33 AM Naga Harish K S V
> <s.v.naga.harish.k at intel.com> wrote:
> >
> > Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" for
> > creating Rx adapter instance. This API is similar to
> > rte_event_eth_rx_adapter_create_ext() with an additional input
> > argument for adapter configuration parameters of type "struct
> > rte_event_eth_rx_adapter_params".
> >
> > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k at intel.com>
> 
> > + */
> > +__rte_experimental
> > +int __rte_cold
> 
> Is there any specific reason to keep __rte_cold here? None of the other
> libraries has this.

__rte_cold is a hint function in the cold path. It is used for code optimization purposes
and many net PMDs are using this.
 
> Rest looks good to me.
> 
> For library changes, please keep all evendev maintainers in Cc. I have added
> those now for this email.
> 
> 
> > +rte_event_eth_rx_adapter_create_ext_with_params(uint8_t id, uint8_t
> dev_id,
> > +                       rte_event_eth_rx_adapter_conf_cb conf_cb,
> > +                       void *conf_arg,
> > +                       struct rte_event_eth_rx_adapter_params
> > +*rxa_params);