[PATCH v2 1/8] net/ntnic: initial commit which adds register defines

[Mykola Kostenok]

Thanks. Good catch. Accepted.

> -----Original Message-----
> From: Tyler Retzlaff <roretzla at linux.microsoft.com>
> Sent: Friday, August 18, 2023 1:09 AM
> To: Mykola Kostenok <mko-plv at napatech.com>
> Cc: dev at dpdk.org; Christian Koue Muf <ckm at napatech.com>
> Subject: Re: [PATCH v2 1/8] net/ntnic: initial commit which adds register
> defines
> 
> On Thu, Aug 17, 2023 at 04:43:05PM +0200, Mykola Kostenok wrote:
> > From: Christian Koue Muf <ckm at napatech.com>
> >
> > The NTNIC PMD does not rely on a kernel space Napatech driver, thus
> > all defines related to the register layout is part of the PMD code,
> > which will be added in later commits.
> >
> > Signed-off-by: Christian Koue Muf <ckm at napatech.com>
> > Reviewed-by: Mykola Kostenok <mko-plv at napatech.com>
> > ---
> >
> drivers/net/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmeson.bu
> ild&c=E,1,c156wt4VMYHsQ_FY06uE-B1pGyaYNwecOQ-XgYTxQ-
> sEVxXYcRzmo8p5zvB3AoN4L_0P4vtVDdYAe8fufFu83lS8RGCTi26L_5wJg6s9-
> x5sIzJg&typo=1                       |    1 +
> >  drivers/net/ntnic/include/fpga_model.h        |   99 +
> >
> drivers/net/ntnic/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fme
> son.build&c=E,1,ZYui3lhpAaB9drSKM2VpYXdH_wzEWBpNMmZdLjmC19weBv
> afwLSTVbJz-
> CEi4jjp1YlftAt12gX0UAKmypCNhhDaAZNmziRKxEv3a69raQ,,&typo=1
> |   29 +
> >  drivers/net/ntnic/nthw/nthw_register.h        |   19 +
> >  .../supported/nthw_fpga_9563_055_024_0000.c   | 4190 ++++++++++
> >  .../nthw/supported/nthw_fpga_instances.h      |   14 +
> >  .../nthw/supported/nthw_fpga_modules_defs.h   |  166 +
> >  .../supported/nthw_fpga_parameters_defs.h     |  209 +
> >  .../nthw/supported/nthw_fpga_registers_defs.h | 7277
> > +++++++++++++++++
> >  9 files changed, 12004 insertions(+)
> >  create mode 100644 drivers/net/ntnic/include/fpga_model.h
> >  create mode 100644
> > drivers/net/ntnic/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2f
> >
> meson.build&c=E,1,qiO2jreaEnViAwfKF0yAabA5ltx6OuQTyXPKL1CEOtHAJNv4
> 1EcJ
> > fd8PkWWUu7_1joAueaPENflIstjA1nB7iHDBk8g3mUvawgO-
> g6qgJw,,&typo=1
> >  create mode 100644 drivers/net/ntnic/nthw/nthw_register.h
> >  create mode 100644
> > drivers/net/ntnic/nthw/supported/nthw_fpga_9563_055_024_0000.c
> >  create mode 100644
> > drivers/net/ntnic/nthw/supported/nthw_fpga_instances.h
> >  create mode 100644
> > drivers/net/ntnic/nthw/supported/nthw_fpga_modules_defs.h
> >  create mode 100644
> > drivers/net/ntnic/nthw/supported/nthw_fpga_parameters_defs.h
> >  create mode 100644
> > drivers/net/ntnic/nthw/supported/nthw_fpga_registers_defs.h
> >
> 
> ...
> 
> > diff --git
> > a/drivers/net/ntnic/https://linkprotect.cudasvc.com/url?a=https%3a%2f%
> > 2fmeson.build&c=E,1,wjptlM2nMhsaqMywVruBxBf7Iwa4gnfYg0S6VTIF-
> NwOmhEZbH
> > kPCwsilEoTcVmtpWO81GLKY8FuRSm-qE1r5zKd-
> 17oCsAXdsYuPlaJNTlyx6WJy1D4zO9x
> > l5g,&typo=1
> > b/drivers/net/ntnic/https://linkprotect.cudasvc.com/url?a=https%3a%2f%
> > 2fmeson.build&c=E,1,Vr72t7YiUD4v0n-
> Lhyp4R59sZz3UaPNjF0lvx7NtZF12XRido9
> > eNWpHDZ-yu-163BxDRG_bu6Hrd47xG6AdPy_U51jZkjSS68uUh0DYrhZxK-
> qnNuORuGoE,
> > &typo=1
> > new file mode 100644
> > index 0000000000..99569c2843
> > --- /dev/null
> > +++ b/drivers/net/ntnic/https://linkprotect.cudasvc.com/url?a=https%3a
> > +++ %2f%2fmeson.build&c=E,1,cf8efsbrpf4Grj2N8OcSe-
> QexkKqF2_tzOZ4hOLUzB
> > +++
> RYRr6AjKPAC6xDsNYOzZm5fReuyiydIkeuWUs4tdzMJR79dQs_0r2jDA11AToOX
> ZOI
> > +++ xUW5VSKbc0Qz&typo=1
> > @@ -0,0 +1,29 @@
> > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2020-2023
> > +Napatech A/S
> > +
> > +# cflags
> > +cflags += [
> > +    '-std=c11',
> > +]
> 
> shouldn't be needed dpdk requires c11 conformant compiler and configures it
> in the root project
> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmeson.build&c=E,1,U
> ys7NUWLsmYbHeZHmrhnTMRhOY3f5VWdjL-nsQdprcA9-
> 4V3RJhX5rDcrpNRQ8ajaA4EYFBy7WUFJQcEVsZPnN69jt6S-
> ZrbNuvDTeEbvwjaYLsUjwUSg0Y,&typo=1 with c_std=c11