[PATCH v11 01/16] eal: use rdtsc intrinsic

[Ali Alnubani]

> -----Original Message-----
> From: Ali Alnubani
> Sent: Wednesday, August 30, 2023 6:49 PM
> To: 'Tyler Retzlaff' <roretzla at linux.microsoft.com>
> Cc: 'David Marchand' <david.marchand at redhat.com>; 'dev at dpdk.org'
> <dev at dpdk.org>; 'Bruce Richardson' <bruce.richardson at intel.com>;
> 'Konstantin Ananyev' <konstantin.v.ananyev at yandex.ru>; 'Ciara Power'
> <ciara.power at intel.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas at monjalon.net>; 'mb at smartsharesystems.com'
> <mb at smartsharesystems.com>
> Subject: RE: [PATCH v11 01/16] eal: use rdtsc intrinsic
> 
> > -----Original Message-----
> > From: Ali Alnubani <alialnu at nvidia.com>
> > Sent: Wednesday, August 30, 2023 4:38 PM
> > To: Tyler Retzlaff <roretzla at linux.microsoft.com>
> > Cc: David Marchand <david.marchand at redhat.com>; dev at dpdk.org; Bruce
> > Richardson <bruce.richardson at intel.com>; Konstantin Ananyev
> > <konstantin.v.ananyev at yandex.ru>; Ciara Power <ciara.power at intel.com>;
> > NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas at monjalon.net>;
> > mb at smartsharesystems.com
> > Subject: RE: [PATCH v11 01/16] eal: use rdtsc intrinsic
> >
> > > -----Original Message-----
> > > From: Tyler Retzlaff <roretzla at linux.microsoft.com>
> > > Sent: Tuesday, August 29, 2023 7:16 PM
> > > To: Ali Alnubani <alialnu at nvidia.com>
> > > Cc: David Marchand <david.marchand at redhat.com>; dev at dpdk.org;
> Bruce
> > > Richardson <bruce.richardson at intel.com>; Konstantin Ananyev
> > > <konstantin.v.ananyev at yandex.ru>; Ciara Power
> <ciara.power at intel.com>;
> > > NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas at monjalon.net>;
> > > mb at smartsharesystems.com
> > > Subject: Re: [PATCH v11 01/16] eal: use rdtsc intrinsic
> > >
> > > On Sat, Aug 26, 2023 at 02:38:26PM +0000, Ali Alnubani wrote:
> > > > > -----Original Message-----
> > > > > From: Tyler Retzlaff <roretzla at linux.microsoft.com>
> > > > > Sent: Friday, August 11, 2023 10:21 PM
> > > > > To: dev at dpdk.org
> > > > > Cc: Bruce Richardson <bruce.richardson at intel.com>; Konstantin
> > Ananyev
> > > > > <konstantin.v.ananyev at yandex.ru>; Ciara Power
> > > <ciara.power at intel.com>;
> > > > > NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas at monjalon.net>;
> > > > > david.marchand at redhat.com; mb at smartsharesystems.com; Tyler
> > > Retzlaff
> > > > > <roretzla at linux.microsoft.com>
> > > > > Subject: [PATCH v11 01/16] eal: use rdtsc intrinsic
> > > > >
> > > > > Inline assembly is not supported for MSVC x64. Convert code to use
> > > > > __rdtsc intrinsic.
> > > > >
> > > > > Signed-off-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
> > > > > Acked-by: Konstantin Ananyev <konstantin.v.ananyev at yandex.ru>
> > > > > Acked-by: Morten Brørup <mb at smartsharesystems.com>
> > > > > ---
> > > >
> > > > Hello,
> > > >
> > > > This patch is causing a build failure in Windows with Clang 11:
> > >
> > > Hi Ali,
> > >
> > > while we don't currently document a minimum clang version required to
> > > build the windows port i'm starting to consider establishing policy that
> > > in effect says we may bump the required compiler version on any dpdk
> > > release (not just long term servicing releases). but before doing that
> > > it would be nice to understand if that would cause undue pain on the
> > > port users.
> > >
> > > So is there a reason you can't use LLVM 16?
> >
> > No specific reason. I reported this because compilation was passing with
> Clang
> > 11 prior to this patch.
> >
> 
> Building with clang version 16.0.6 fails for me with:
> 
> [..]
> [405/803] Linking target lib/rte_eal-24.dll
> FAILED: lib/rte_eal-24.dll
> "clang" @lib/rte_eal-24.dll.rsp
> clang: error: no such file or directory: 'librte_log.lib'
> clang: error: no such file or directory: 'librte_kvargs.lib'
> [406/803] Compiling C object
> lib/librte_mempool.a.p/mempool_rte_mempool_ops_default.c.obj
> [..]

This build failure was actually caused by upgrading Meson from 0.54.3 to 1.2.1 earlier on the environment.
The build passes with Meson 0.54.3 and Clang 16.0.6.