[RFC v2 13/14] lib: replace logging helpers

Andrew Rybchenko andrew.rybchenko at oktetlabs.ru
Sat Dec 16 10:42:51 CET 2023


On 12/8/23 17:59, David Marchand wrote:
> This is a preparation step before the next change.
> 
> Many libraries have their own logging helpers that do not add a newline
> in their format string.
> Some previous changes fixed places where some of those helpers are
> called without a trailing newline.
> Using RTE_LOG_LINE in the existing helpers will ensure we don't
> introduce new issues in the future.
> 
> The problem is that if we simply convert to the RTE_LOG_LINE helper,
> a future fix may introduce a regression since the logging helper
> change won't be backported.
> 
> To address this concern, rename existing helpers: backporting a call to
> them will trigger some conflict or build issue in LTS branches.
> 
> Note:
> - bpf and vhost that still has some debug multilines messages, a direct
>    call to RTE_LOG/RTE_LOG_DP is used: this will make it easier to notice
>    such special cases,
> - about previously publicly exposed logging helpers, when such helper is
>    not publicly used (iow in public inline API), it is removed from the
>    public API (this is the case for the member library),
> 
> Signed-off-by: David Marchand <david.marchand at redhat.com>

For ethdev
Reviewed-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>




More information about the dev mailing list