[PATCH] devtools: forbid writing to standard output streams
David Marchand
david.marchand at redhat.com
Thu Dec 21 14:31:20 CET 2023
No output on stdout or stderr!
Drivers and libraries must use the logging framework.
Signed-off-by: David Marchand <david.marchand at redhat.com>
---
devtools/checkpatches.sh | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 10d1bf490b..c9e466f736 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -61,6 +61,14 @@ check_forbidden_additions() { # <patch>
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
+ # no output on stdout or stderr
+ awk -v FOLDERS="lib drivers" \
+ -v EXPRESSIONS="\\\<printf\\\> \\\<fprintf\\\(stdout, \\\<fprintf\\\(stderr," \
+ -v RET_ON_FAIL=1 \
+ -v MESSAGE='Writing to stdout or stderr' \
+ -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+ "$1" || res=1
+
# refrain from new additions of rte_panic() and rte_exit()
# multiple folders and expressions are separated by spaces
awk -v FOLDERS="lib drivers" \
--
2.43.0
More information about the dev
mailing list