[dpdk-dev] [PATCH] examples/ethtool: fix pause configuration

Stephen Hemminger stephen at networkplumber.org
Tue Jul 4 01:19:09 CEST 2023


On Wed, 28 Apr 2021 16:42:59 +0800
"Min Hu (Connor)" <humin29 at huawei.com> wrote:

> From: Huisong Li <lihuisong at huawei.com>
> 
> Currently, the pause command in ethtool to enable Rx/Tx pause has the
> following problem. Namely, Assume that the device supports flow control
> auto-negotiation to set pause parameters, which will the device that does
> not support flow control auto-negotiation fails to run this command.
> 
> This patch supports the configuration of flow control auto-negotiation
> and fixes the print format and style of the pause cmd to make it more
> readable.
> 
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> 
> Signed-off-by: Huisong Li <lihuisong at huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>

Overall, this looks good.
DPDK is mainly used in devices 1G and above where I think that
auto negotiation is required by IEEE spec.

Acked-by: Stephen Hemminger <stephen at networkplumber.org>


More information about the dev mailing list