[PATCH] usertools: enhance logic to display NUMA

[Varghese, Vipin]

[AMD Official Use Only - General]

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Tuesday, July 11, 2023 9:56 PM
> To: Varghese, Vipin <Vipin.Varghese at amd.com>; Stephen Hemminger
> <stephen at networkplumber.org>
> Cc: david.marchand at redhat.com; Tummala, Sivaprasad
> <Sivaprasad.Tummala at amd.com>; dev at dpdk.org
> Subject: Re: [PATCH] usertools: enhance logic to display NUMA
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> 11/07/2023 17:42, Stephen Hemminger:
> > On Sat, 26 Mar 2022 00:32:07 -0700
> > Vipin Varghese <vipin.varghese at amd.com> wrote:
> >
> > > +
> > > +  output = " Socket " + str(socket).ljust(3, ' ') + " Numa " +
> str(numa).zfill(1) + " "
> > > +  #output = " Socket " + str(socket).zfill(1) + " Numa " + str(numa).zfill(1) +
> " "
> > > +  print(output)
> > > +  print(format("-" * len(output)))
> > > +
> > > +  for index,coreSibling in enumerate(numa_map[keys]):
> > > +      print ("Core " + str(index).ljust(3, ' ') + "    " + str(coreSibling))
> > > +      #print ("Core " + str(index).zfill(3) + "    " + str(coreSibling))
> > > +print("")
> > > +
> >
> > Git complains because you added new blank line at end of file.
> >
> > One wording suggestion would be to use the term "Node" instead of
> "Numa" in the table.
> > And fix heading alignment. The new headings don't look right.
> >
> > For the case with only single socket, single node, some of the
> > headings could be dropped as well.
>
> I don't understand why we continue working on this script.
> I thought we agreed it should be removed in favor of lstopo.
>

Sorry Thomas, I did not follow your ` I don't understand why we continue working on this script. I thought we agreed it should be removed in favor of lstopo.`

>From last email from my end `we should promote and document the changes provided the existing tool is phased out and use lstopo`.

Note:
1. This is with assumption that both Linux and Windows `lstopo` is modified and handles `ACPI L3 SRAT NUMA` and `Node per Socket NUMA`.
2. I have not seen a depreciation notice for cpu_layout.py too.