[PATCH] doc: add deprecation notice for inconsistent socket_id types
Stephen Hemminger
stephen at networkplumber.org
Sun Jul 16 19:34:44 CEST 2023
On Fri, 14 Oct 2022 10:09:44 +0200
Markus Theil <markus.theil at tu-ilmenau.de> wrote:
> DPDK uses many different types for socket_id's in its whole code
> base. This leads to many warnings and casts in DPDK-based applications
> compiled with -Wconversion.
>
> Announce a treewide consolidation to the return type of rte_socket_id
> in DPDK 23.11.
>
> Signed-off-by: Markus Theil <markus.theil at tu-ilmenau.de>
Yes, this is a problem. But it is a bug not something that needs a deprecation
notice. The DPDK has avoided using typedefs for port, queue, lcore, and socket.
With socket_id there is the need to represent SOCKET_ID_ANY which is -1.
Please file a bugzilla entry instead.
Looking at code, there a few places doing using uint8_t which will work since
no cpu at present supports that many numa nodes. Should probably be a compile
assert for that though.
More information about the dev
mailing list