[PATCH] eal: fix prompt info when remap_segment failed

[David Marchand]

On Mon, May 29, 2023 at 1:22 PM Fengnan Chang
<changfengnan at bytedance.com> wrote:
>
> when there is enough space for memseg, we should pormpt which
> config to modify, not just print numbers.

I think you want to explain the case when there is *not* enough
objects declared in the static configuration.
Could you rephrase and fix the typos?


>
> Signed-off-by: Fengnan Chang <changfengnan at bytedance.com>
> ---
>  lib/eal/linux/eal_memory.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c
> index 0876974631..974db901b7 100644
> --- a/lib/eal/linux/eal_memory.c
> +++ b/lib/eal/linux/eal_memory.c
> @@ -716,9 +716,8 @@ remap_segment(struct hugepage_file *hugepages, int seg_start, int seg_end)
>                 break;
>         }
>         if (msl_idx == RTE_MAX_MEMSEG_LISTS) {
> -               RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase %s and/or %s in configuration.\n",
> -                               RTE_STR(RTE_MAX_MEMSEG_PER_TYPE),
> -                               RTE_STR(RTE_MAX_MEM_MB_PER_TYPE));
> +               RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase RTE_MAX_MEMSEG_PER_LIST "
> +                               "RTE_MAX_MEMSEG_PER_TYPE and/or RTE_MAX_MEM_MB_PER_TYPE in configuration.\n");

This same log is in FreeBSD, so I guess we want to update it too.


-- 
David Marchand