[PATCH v2 2/3] bus/cdx: move debug print before unmapping resource
Abhijit Gangurde
abhijit.gangurde at amd.com
Fri Jun 16 14:39:09 CEST 2023
Move debug print before unmapping requested address
to fix use after free coverity issue.
Coverity issue: 385381
Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus")
Signed-off-by: Abhijit Gangurde <abhijit.gangurde at amd.com>
---
v2:
- Updated commit message
drivers/bus/cdx/cdx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c
index 9130c30515..aef19682f4 100644
--- a/drivers/bus/cdx/cdx.c
+++ b/drivers/bus/cdx/cdx.c
@@ -322,12 +322,13 @@ cdx_unmap_resource(void *requested_addr, size_t size)
if (requested_addr == NULL)
return;
+ CDX_BUS_DEBUG("Unmapping CDX memory at %p", requested_addr);
+
/* Unmap the CDX memory resource of device */
if (rte_mem_unmap(requested_addr, size)) {
CDX_BUS_ERR("%s(): cannot mem unmap(%p, %#zx): %s", __func__,
requested_addr, size, rte_strerror(rte_errno));
}
- CDX_BUS_DEBUG("CDX memory unmapped at %p", requested_addr);
}
/*
* Match the CDX Driver and Device using device id and vendor id.
--
2.25.1
More information about the dev
mailing list