[EXT] Re: [PATCH] lib: fix coverity for unused variable

[Thomas Monjalon]

27/06/2023 23:52, Thomas Monjalon:
> 27/06/2023 18:05, Amit Prakash Shukla:
> > From: Thomas Monjalon <thomas at monjalon.net>
> > > 16/06/2023 13:06, Amit Prakash Shukla:
> > > > Removed variable "rc" that stored a return value from a function
> > > > rte_lpm6_lookup_bulk_func.
> > > 
> > > You are not really removing the variable, right?
> > > It looks you just stop storing the return of this function.
> > > Whouldn't it better to check the return code?
> > 
> > Yes, I am just not storing the return value. The reason to not
> > store return code is to avoid return code check in datapath.
> > rte_lpm6_lookup_bulk_func will return error only if
> >  lpm6, ip_batch, next_hop are NULL. In function ip6_lookup_node_process_scalar
> > these variables will never be NULL.
> 
> I will update the commit message accordingly.

Applied with updated explanation:

    node: remove useless return code assignment
    
    No need to store the return code of rte_lpm6_lookup_bulk_func()
    as it returns error only if parameters are NULL.
    In the function ip6_lookup_node_process_scalar(),
    these variables will never be NULL.
    
    Not checking the return code will avoid check in datapath.
    Storing of the return code is useless and removed.