[dpdk-dev] [PATCH] net/liquidio: removed LiquidIO ethdev driver

[Ferruh Yigit]

On 4/28/2023 11:31 AM, jerinj at marvell.com wrote:
> From: Jerin Jacob <jerinj at marvell.com>
> 
> The LiquidIO product line has been substituted with CN9K/CN10K
> OCTEON product line smart NICs located at drivers/net/octeon_ep/.
> 
> DPDK 20.08 has categorized the LiquidIO driver as UNMAINTAINED
> because of the absence of updates in the driver.
> 
> Due to the above reasons, the driver removed from DPDK 23.07.
> 
> Also removed deprecation notice entry for the removal in
> doc/guides/rel_notes/deprecation.rst.
> 
> Signed-off-by: Jerin Jacob <jerinj at marvell.com>
> ---
>  MAINTAINERS                              |    8 -
>  doc/guides/nics/features/liquidio.ini    |   29 -
>  doc/guides/nics/index.rst                |    1 -
>  doc/guides/nics/liquidio.rst             |  169 --
>  doc/guides/rel_notes/deprecation.rst     |    7 -
>  doc/guides/rel_notes/release_23_07.rst   |    9 +-
>  drivers/net/liquidio/base/lio_23xx_reg.h |  165 --
>  drivers/net/liquidio/base/lio_23xx_vf.c  |  513 ------
>  drivers/net/liquidio/base/lio_23xx_vf.h  |   63 -
>  drivers/net/liquidio/base/lio_hw_defs.h  |  239 ---
>  drivers/net/liquidio/base/lio_mbox.c     |  246 ---
>  drivers/net/liquidio/base/lio_mbox.h     |  102 -
>  drivers/net/liquidio/lio_ethdev.c        | 2147 ----------------------
>  drivers/net/liquidio/lio_ethdev.h        |  179 --
>  drivers/net/liquidio/lio_logs.h          |   58 -
>  drivers/net/liquidio/lio_rxtx.c          | 1804 ------------------
>  drivers/net/liquidio/lio_rxtx.h          |  740 --------
>  drivers/net/liquidio/lio_struct.h        |  661 -------
>  drivers/net/liquidio/meson.build         |   16 -
>  drivers/net/meson.build                  |    1 -
>  20 files changed, 1 insertion(+), 7156 deletions(-)
>  delete mode 100644 doc/guides/nics/features/liquidio.ini
>  delete mode 100644 doc/guides/nics/liquidio.rst
>  delete mode 100644 drivers/net/liquidio/base/lio_23xx_reg.h
>  delete mode 100644 drivers/net/liquidio/base/lio_23xx_vf.c
>  delete mode 100644 drivers/net/liquidio/base/lio_23xx_vf.h
>  delete mode 100644 drivers/net/liquidio/base/lio_hw_defs.h
>  delete mode 100644 drivers/net/liquidio/base/lio_mbox.c
>  delete mode 100644 drivers/net/liquidio/base/lio_mbox.h
>  delete mode 100644 drivers/net/liquidio/lio_ethdev.c
>  delete mode 100644 drivers/net/liquidio/lio_ethdev.h
>  delete mode 100644 drivers/net/liquidio/lio_logs.h
>  delete mode 100644 drivers/net/liquidio/lio_rxtx.c
>  delete mode 100644 drivers/net/liquidio/lio_rxtx.h
>  delete mode 100644 drivers/net/liquidio/lio_struct.h
>  delete mode 100644 drivers/net/liquidio/meson.build
> 

This cause warning in the ABI check script [1], not because there is an
ABI breakage, but because how script works, that needs to be fixed as well.

[1]
Checking ABI compatibility of build-gcc-shared
.../dpdk-next-net/devtools/../devtools/check-abi.sh
/tmp/dpdk-abiref/v22.11.1/build-gcc-shared
.../dpdk-next-net/build-gcc-shared/install
Error: cannot find librte_net_liquidio.so.23.0 in
.../dpdk-next-net/build-gcc-shared/install

<...>

> --- a/doc/guides/rel_notes/release_23_07.rst
> +++ b/doc/guides/rel_notes/release_23_07.rst
> @@ -59,14 +59,7 @@ New Features
>  Removed Items
>  -------------
>  
> -.. This section should contain removed items in this release. Sample format:
> -
> -   * Add a short 1-2 sentence description of the removed item
> -     in the past tense.
> -
> -   This section is a comment. Do not overwrite or remove it.
> -   Also, make sure to start the actual text at the margin.
> -   =======================================================
> +* Removed LiquidIO ethdev driver located at ``drivers/net/liquidio/``
>  
>  

No need to remove the section comment.

Rest looks good to me.