[PATCH v1] devtools: allow variable declaration inside for loop
Ferruh Yigit
ferruh.yigit at amd.com
Wed May 3 11:50:18 CEST 2023
Declaring variable inside for loop is not supported via C89 and it was
checked in checkpatch.sh via commit [1].
But as DPDK supported C standard is becoming C99 [2], declaring variable
inside loop can be allowed.
[1]
Commit 43e73483a4b8 ("devtools: forbid variable declaration inside for")
[2]
https://dpdk.org/patch/121912
Signed-off-by: Ferruh Yigit <ferruh.yigit at amd.com>
---
Cc: Bruce Richardson <bruce.richardson at intel.com>
Cc: David Marchand <david.marchand at redhat.com>
---
devtools/checkpatches.sh | 8 --------
1 file changed, 8 deletions(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 15d5d6709445..b5baf6f2b161 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -78,14 +78,6 @@ check_forbidden_additions() { # <patch>
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
- # forbid variable declaration inside "for" loop
- awk -v FOLDERS='.' \
- -v EXPRESSIONS='for[[:space:]]*\\((char|u?int|unsigned|s?size_t)' \
- -v RET_ON_FAIL=1 \
- -v MESSAGE='Declaring a variable inside for()' \
- -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
- "$1" || res=1
-
# refrain from new additions of 16/32/64 bits rte_atomicNN_xxx()
awk -v FOLDERS="lib drivers app examples" \
-v EXPRESSIONS="rte_atomic[0-9][0-9]_.*\\\(" \
--
2.34.1
More information about the dev
mailing list