[PATCH] net/bonding: replace master/slave to main/member

Stephen Hemminger stephen at networkplumber.org
Wed May 17 16:52:38 CEST 2023


On Wed, 17 May 2023 14:59:05 +0800
Chaoyong He <chaoyong.he at corigine.com> wrote:

> This patch replaces the usage of the word 'master/slave' with more
> appropriate word 'main/member' in bonding PMD as well as in its docs
> and examples. Also the test app and testpmd were modified to use the
> new wording.
> 
> The bonding PMD's public API was modified according to the changes
> in word:
> rte_eth_bond_8023ad_slave_info is now called
> rte_eth_bond_8023ad_member_info,
> rte_eth_bond_active_slaves_get is now called
> rte_eth_bond_active_members_get,
> rte_eth_bond_slave_add is now called
> rte_eth_bond_member_add,
> rte_eth_bond_slave_remove is now called
> rte_eth_bond_member_remove,
> rte_eth_bond_slaves_get is now called
> rte_eth_bond_members_get.
> 
> Also the macro RTE_ETH_DEV_BONDED_SLAVE was renamed to
> RTE_ETH_DEV_BONDED_MEMBER.
> 
> Signed-off-by: Long Wu <long.wu at corigine.com>
> Acked-by: Niklas Söderlund <niklas.soderlund at corigine.com>
> Reviewed-by: James Hershaw <james.hershaw at corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he at corigine.com>
> ---

This looks great.

I had started on this and chose the new names as parent and child,
but that choice was arbitrary.  Did some background research and

============ ================== ============== ===============
Origin       Feature Name       Aggregate Name Device Name
============ ================== ============== ===============
IEEE 802.1AX Link Aggregation   aggregator     port
Linux        Bonding            master         slave
FreeBSD      Link Aggregate     lagg           laggport
Windows      Teaming            team
OpenVswitch  Bonding            bond           members
Solaris      Link Aggregate     aggregation    datalink
Cisco        EtherChannel       group          channel
Juniper      Aggregate Ethernet lag interface  lag link
Arista       Port Channel       group          channel
SONiC        LAG                portchannel    member
============ ================== ============== ===============


You also need to modify how this is done since it ends up
being an API change.

My version of the patch had some of that, if you want here it is.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-bonding-replace-use-of-slave-device-with-child-devic.patch
Type: text/x-patch
Size: 566286 bytes
Desc: not available
URL: <http://mails.dpdk.org/archives/dev/attachments/20230517/cc3f9ac6/attachment-0001.bin>


More information about the dev mailing list