[EXT] [PATCH] ethdev: fix asynchronous destroy and push tracepoints

Ankur Dwivedi adwivedi at marvell.com
Fri May 19 07:21:03 CEST 2023


>The rte_flow_async_destroy() and rte_flow_push() API is intended to be as
>fast as possible and tracepoints for these functions must be marked as fast-
>path tracepoints.
>
>Fixes: 6679cf21d608 ("ethdev: add trace points")
>
>Signed-off-by: Alexander Kozyrev <akozyrev at nvidia.com>

Acked-by: Ankur Dwivedi <adwivedi at marvell.com>
>---
> lib/ethdev/ethdev_trace.h | 42 +++++++++++++++++++--------------------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
>diff --git a/lib/ethdev/ethdev_trace.h b/lib/ethdev/ethdev_trace.h index
>ba7871aa3e..c8498b19e3 100644
>--- a/lib/ethdev/ethdev_trace.h
>+++ b/lib/ethdev/ethdev_trace.h
>@@ -1582,27 +1582,6 @@ RTE_TRACE_POINT(
> 	rte_trace_point_emit_int(ret);
> )
>
>-RTE_TRACE_POINT(
>-	rte_flow_trace_async_destroy,
>-	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id,
>-		const struct rte_flow_op_attr *op_attr,
>-		const struct rte_flow *flow, const void *user_data, int ret),
>-	rte_trace_point_emit_u16(port_id);
>-	rte_trace_point_emit_u32(queue_id);
>-	rte_trace_point_emit_ptr(op_attr);
>-	rte_trace_point_emit_ptr(flow);
>-	rte_trace_point_emit_ptr(user_data);
>-	rte_trace_point_emit_int(ret);
>-)
>-
>-RTE_TRACE_POINT(
>-	rte_flow_trace_push,
>-	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, int
>ret),
>-	rte_trace_point_emit_u16(port_id);
>-	rte_trace_point_emit_u32(queue_id);
>-	rte_trace_point_emit_int(ret);
>-)
>-
> RTE_TRACE_POINT(
> 	rte_mtr_trace_capabilities_get,
> 	RTE_TRACE_POINT_ARGS(uint16_t port_id, @@ -2356,6 +2335,19
>@@ RTE_TRACE_POINT_FP(
> 	rte_trace_point_emit_ptr(flow);
> )
>
>+RTE_TRACE_POINT_FP(
>+	rte_flow_trace_async_destroy,
>+	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id,
>+		const struct rte_flow_op_attr *op_attr,
>+		const struct rte_flow *flow, const void *user_data, int ret),
>+	rte_trace_point_emit_u16(port_id);
>+	rte_trace_point_emit_u32(queue_id);
>+	rte_trace_point_emit_ptr(op_attr);
>+	rte_trace_point_emit_ptr(flow);
>+	rte_trace_point_emit_ptr(user_data);
>+	rte_trace_point_emit_int(ret);
>+)
>+
> RTE_TRACE_POINT_FP(
> 	rte_flow_trace_async_update,
> 	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, @@ -
>2374,6 +2366,14 @@ RTE_TRACE_POINT_FP(
> 	rte_trace_point_emit_int(ret);
> )
>
>+RTE_TRACE_POINT_FP(
>+	rte_flow_trace_push,
>+	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, int
>ret),
>+	rte_trace_point_emit_u16(port_id);
>+	rte_trace_point_emit_u32(queue_id);
>+	rte_trace_point_emit_int(ret);
>+)
>+
> RTE_TRACE_POINT_FP(
> 	rte_flow_trace_pull,
> 	RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id,
>--
>2.18.2



More information about the dev mailing list