[v4] net/gve: check driver compatibility

[Rushil Gupta]

We are not validating anything.
This is for our internal analysis and product requirements.

On Fri, May 19, 2023 at 1:56 PM Stephen Hemminger <
stephen at networkplumber.org> wrote:

> On Fri, 19 May 2023 13:46:18 -0700
> Rushil Gupta <rushilg at google.com> wrote:
>
> > +#include <rte_version.h>
> >
> >  #include "../gve_logs.h"
> >
> > +#ifdef __linux__
> > +#include <sys/utsname.h>
> > +#endif
> > +
> >  typedef uint8_t u8;
> >  typedef uint16_t u16;
> >  typedef uint32_t u32;
> > @@ -73,6 +78,12 @@ typedef rte_iova_t dma_addr_t;
> >
> >  #define msleep(ms)           rte_delay_ms(ms)
> >
> > +#define OS_VERSION_STRLEN 128
> > +struct os_version_string {
> > +     char os_version_str1[OS_VERSION_STRLEN];
> > +     char os_version_str2[OS_VERSION_STRLEN];
> > +};
> > +
>
> Not sure this a good idea. Are you having the host validate
> against DPDK versions. This is a bad idea.
>
> Better to use feature bits like virtio and not be creating
> and validating strings about versions.  For example, ever minor
> stable release changes this.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mails.dpdk.org/archives/dev/attachments/20230520/a40360fb/attachment.htm>