[PATCH v3 21/22] pdcp: add thread safe processing

[Stephen Hemminger]

On Wed, 24 May 2023 21:31:15 +0530
Anoob Joseph <anoobj at marvell.com> wrote:

> From: Volodymyr Fialko <vfialko at marvell.com>
> 
> PDCP state has to be guarded for:
> 
> - Uplink pre_process:
>     - tx_next atomic increment
> 
> - Downlink pre_process:
>     - rx_deliv - read
> 
> - Downlink post_process:
>     - rx_deliv, rx_reorder, rx_next - read/write
>     - bitmask/reorder buffer - read/write
> 
> When application requires thread safe processing, the state variables
> need to be updated atomically. Add config option to select this option
> per entity.
> 
> Signed-off-by: Anoob Joseph <anoobj at marvell.com>
> Signed-off-by: Volodymyr Fialko <vfialko at marvell.com>

NAK
Conditional locking is a bad design pattern.
It leads to lots of problems, and makes it almost impossible for analysis tools.