[PATCH v3 18/28] vhost: add VDUSE device creation and destruction

[David Marchand]

On Thu, May 25, 2023 at 6:27 PM Maxime Coquelin
<maxime.coquelin at redhat.com> wrote:
> diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c
> new file mode 100644
> index 0000000000..d67818bfb5
> --- /dev/null
> +++ b/lib/vhost/vduse.c

[snip]

> +#define VDUSE_NET_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \
> +                               (1ULL << VIRTIO_F_ANY_LAYOUT) | \
> +                               (1ULL << VIRTIO_F_VERSION_1)   | \
> +                               (1ULL << VIRTIO_NET_F_GSO) | \
> +                               (1ULL << VIRTIO_NET_F_HOST_TSO4) | \
> +                               (1ULL << VIRTIO_NET_F_HOST_TSO6) | \
> +                               (1ULL << VIRTIO_NET_F_HOST_UFO) | \
> +                               (1ULL << VIRTIO_NET_F_HOST_ECN) | \
> +                               (1ULL << VIRTIO_NET_F_CSUM)    | \
> +                               (1ULL << VIRTIO_NET_F_GUEST_CSUM) | \
> +                               (1ULL << VIRTIO_NET_F_GUEST_TSO4) | \
> +                               (1ULL << VIRTIO_NET_F_GUEST_TSO6) | \
> +                               (1ULL << VIRTIO_NET_F_GUEST_UFO) | \
> +                               (1ULL << VIRTIO_NET_F_GUEST_ECN) | \
> +                               (1ULL << VIRTIO_RING_F_INDIRECT_DESC) | \
> +                               (1ULL << VIRTIO_F_IN_ORDER) | \
> +                               (1ULL << VIRTIO_F_IOMMU_PLATFORM))

That's a lot of indent/spaces.

#define VDUSE_NET_SUPPORTED_FEATURES (\
        (1ULL << VIRTIO_NET_F_MRG_RXBUF) | \
        (1ULL << VIRTIO_F_ANY_LAYOUT) | \


Plus, can't we use RTE_BIT64? (this could be a cleanup to do on the
whole vhost library)


-- 
David Marchand