[EXTERNAL] Re: EXTERNAL] [PATCH ] Add checks for the port capabilties

[Ajay Sharma]

>From 1290db88b8748085c9f09a58b336b8c757442b87 Mon Sep 17 00:00:00 2001
 From: Ajay Sharma <sharmaajay at microsoft.com>
 Date: Sun, 28 May 2023 18:31:59 -0700
 Subject: [PATCH] Change USHRT_MAX to UINT16_MAX

 ---
  drivers/net/mana/mana.c | 16 ++++++++--------
  1 file changed, 8 insertions(+), 8 deletions(-)

 diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c
 index 3a7e302c86..a39d6798bf 100644
 --- a/drivers/net/mana/mana.c
 +++ b/drivers/net/mana/mana.c
 @@ -292,8 +292,8 @@ mana_dev_info_get(struct rte_eth_dev *dev,
         dev_info->min_rx_bufsize = MIN_RX_BUF_SIZE;
         dev_info->max_rx_pktlen = MAX_FRAME_SIZE;

 -       dev_info->max_rx_queues = RTE_MIN(priv->max_rx_queues, USHRT_MAX);
 -       dev_info->max_tx_queues = RTE_MIN(priv->max_tx_queues, USHRT_MAX);
 +       dev_info->max_rx_queues = RTE_MIN(priv->max_rx_queues, UINT16_MAX);
 +       dev_info->max_tx_queues = RTE_MIN(priv->max_tx_queues, UINT16_MAX);


         dev_info->max_mac_addrs = MANA_MAX_MAC_ADDR;
 @@ -335,17 +335,17 @@ mana_dev_info_get(struct rte_eth_dev *dev,

         /* Buffer limits */
         dev_info->rx_desc_lim.nb_min = MIN_BUFFERS_PER_QUEUE;
 -       dev_info->rx_desc_lim.nb_max = RTE_MIN(priv->max_rx_desc, USHRT_MAX);
 +       dev_info->rx_desc_lim.nb_max = RTE_MIN(priv->max_rx_desc, UINT16_MAX);
         dev_info->rx_desc_lim.nb_align = MIN_BUFFERS_PER_QUEUE;
 -       dev_info->rx_desc_lim.nb_seg_max = RTE_MIN(priv->max_recv_sge, USHRT_MAX);
 -       dev_info->rx_desc_lim.nb_mtu_seg_max = RTE_MIN(priv->max_recv_sge, USHRT_MAX);
 +       dev_info->rx_desc_lim.nb_seg_max = RTE_MIN(priv->max_recv_sge, UINT16_MAX);
 +       dev_info->rx_desc_lim.nb_mtu_seg_max = RTE_MIN(priv->max_recv_sge, UINT16_MAX);


         dev_info->tx_desc_lim.nb_min = MIN_BUFFERS_PER_QUEUE;
 -       dev_info->tx_desc_lim.nb_max = RTE_MIN(priv->max_tx_desc, USHRT_MAX);
 +       dev_info->tx_desc_lim.nb_max = RTE_MIN(priv->max_tx_desc, UINT16_MAX);
         dev_info->tx_desc_lim.nb_align = MIN_BUFFERS_PER_QUEUE;
 -       dev_info->tx_desc_lim.nb_seg_max = RTE_MIN(priv->max_send_sge, USHRT_MAX);
 -       dev_info->rx_desc_lim.nb_mtu_seg_max = RTE_MIN(priv->max_recv_sge, USHRT_MAX);
 +       dev_info->tx_desc_lim.nb_seg_max = RTE_MIN(priv->max_send_sge, UINT16_MAX);
 +       dev_info->rx_desc_lim.nb_mtu_seg_max = RTE_MIN(priv->max_recv_sge, UINT16_MAX);

         /* Speed */
         dev_info->speed_capa = RTE_ETH_LINK_SPEED_100G;
 --
 2.25.1

> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Thursday, May 25, 2023 8:31 PM
> To: Ajay Sharma <sharmaajay at microsoft.com>
> Cc: Ferruh Yigit <ferruh.yigit at amd.com>; Andrew Rybchenko
> <andrew.rybchenko at oktetlabs.ru>; dev at dpdk.org; Long Li
> <longli at microsoft.com>; stable at dpdk.org
> Subject: [EXTERNAL] Re: EXTERNAL] [PATCH ] Add checks for the port
> capabilties
> 
> On Fri, 26 May 2023 00:19:59 +0000
> Ajay Sharma <sharmaajay at microsoft.com> wrote:
> 
> >   +       dev_info->max_rx_queues = RTE_MIN(priv->max_rx_queues,
> USHRT_MAX);
> >   +       dev_info->max_tx_queues = RTE_MIN(priv->max_tx_queues,
> USHRT_MAX);
> >   +
> 
> Please use UINT16_MAX instead of USHRT_MAX since that is the type of
> max_rx_queues.
> Both are the same size but best to be consistent.