[PATCH v3 4/4] vhost: add device op to offload the interrupt kick

Maxime Coquelin maxime.coquelin at redhat.com
Wed May 31 16:18:12 CEST 2023



On 5/31/23 16:12, David Marchand wrote:
> Maxime,
> 
> On Wed, May 17, 2023 at 11:09 AM Eelco Chaudron <echaudro at redhat.com> wrote:
>> @@ -974,11 +994,8 @@ vhost_vring_call_packed(struct virtio_net *dev, struct vhost_virtqueue *vq)
>>          if (vhost_need_event(off, new, old))
>>                  kick = true;
>>   kick:
>> -       if (kick && vq->callfd >= 0) {
>> -               eventfd_write(vq->callfd, (eventfd_t)1);
>> -               if (dev->notify_ops->guest_notified)
>> -                       dev->notify_ops->guest_notified(dev->vid);
>> -       }
>> +       if (kick && vq->callfd >= 0)
>> +               vhost_vring_inject_irq(dev, vq);
> 
> Thinking again about the VDUSE series overlap...
> 
> This hunk here is implicitely fixing an issue.
> You addressed it in
> https://patchwork.dpdk.org/project/dpdk/patch/20230525162551.70359-2-maxime.coquelin@redhat.com/
> 
> So I suggest you apply this patch of yours before Eelco patch 4.
> This way, the fix backport will be trivial.
> 
> 

Thanks David, this is indeed the best thing to do to ease backporting
the fix to v22.11.

Maxime



More information about the dev mailing list