[PATCH v3 2/5] net/af_packet: use new API to parse kvargs

Ferruh Yigit ferruh.yigit at amd.com
Fri Nov 3 14:11:57 CET 2023


On 11/3/2023 7:38 AM, Chengwen Feng wrote:
> This driver don't care about the 'iface' value, it should use
> rte_kvargs_process_opt() instead of rte_kvargs_process() to parse.
> 
> Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
> ---
>  drivers/net/af_packet/rte_eth_af_packet.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
> index 397a32db58..54a9f5f746 100644
> --- a/drivers/net/af_packet/rte_eth_af_packet.c
> +++ b/drivers/net/af_packet/rte_eth_af_packet.c
> @@ -1096,8 +1096,8 @@ rte_pmd_af_packet_probe(struct rte_vdev_device *dev)
>  	 */
>  	if (rte_kvargs_count(kvlist, ETH_AF_PACKET_IFACE_ARG) == 1) {
>  
> -		ret = rte_kvargs_process(kvlist, ETH_AF_PACKET_IFACE_ARG,
> -		                         &open_packet_iface, &sockfd);
> +		ret = rte_kvargs_process_opt(kvlist, ETH_AF_PACKET_IFACE_ARG,
> +					     &open_packet_iface, &sockfd);
>  		if (ret < 0)
>  			goto exit;
>  	}

lets not update this driver, I think it is using kvargs
unconventionally, 'iface' requires argument but driver parses it
directly from kvargs.

We can fix kvargs usage more properly instead of this change, I am
taking a mental note for this.


More information about the dev mailing list