[PATCH v9 1/9] ethdev: overwrite some comment related to RSS

Andrew Rybchenko andrew.rybchenko at oktetlabs.ru
Mon Nov 6 11:57:26 CET 2023


On 11/2/23 11:20, Jie Hai wrote:
> In rte_eth_dev_rss_hash_conf_get(), the "rss_key_len" should be
> greater than or equal to the "hash_key_size" which get from
> rte_eth_dev_info_get() API. And the "rss_key" should contain at
> least "hash_key_size" bytes. If these requirements are not met,
> the query unreliable.
> 
> In rte_eth_dev_rss_hash_update() or rte_eth_dev_configure(), the
> "rss_key_len" indicates the length of the "rss_key" in bytes of
> the array pointed by "rss_key", it should be equal to the
> "hash_key_size" if "rss_key" is not NULL.
> 
> This patch overwrites the comments of fields of "rte_eth_rss_conf"
> and "RTE_ETH_HASH_FUNCTION_DEFAULT", checks "rss_key_len" in
> ethdev level, and documents these changes.
> 
> Signed-off-by: Jie Hai <haijie1 at huawei.com>
> Acked-by: Huisong Li <lihuisong at huawei.com>
> Acked-by: Chengwen Feng <fengchengwen at huawei.com>


<snip>

> @@ -4712,6 +4730,7 @@ int
>   rte_eth_dev_rss_hash_conf_get(uint16_t port_id,
>   			      struct rte_eth_rss_conf *rss_conf)
>   {
> +	struct rte_eth_dev_info dev_info = { 0 };

There is no poiint to init dev_info here. Get functoin does it anyway.



More information about the dev mailing list