[PATCH v3 1/2] app/testpmd: remove useless code for TSO setting command
Huisong Li
lihuisong at huawei.com
Tue Nov 7 05:11:16 CET 2023
Testpmd has added the check of TSO offload capability of port, please see
the commit 3926dd2b6668 ("app/testpmd: enforce offload capabilities check")
So the code following the check code memtioned above to display warning
when port doesn't support TSO offload doesn't access to forever.
Fixes: 3926dd2b6668 ("app/testpmd: enforce offload capabilities check")
Cc: stable at dpdk.org
Signed-off-by: Huisong Li <lihuisong at huawei.com>
---
app/test-pmd/cmdline.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 912bf3355c..1c57e07d41 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -4967,19 +4967,6 @@ cmd_tso_set_parsed(void *parsed_result,
ports[res->port_id].tso_segsz);
}
cmd_config_queue_tx_offloads(&ports[res->port_id]);
-
- /* display warnings if configuration is not supported by the NIC */
- ret = eth_dev_info_get_print_err(res->port_id, &dev_info);
- if (ret != 0)
- return;
-
- if ((ports[res->port_id].tso_segsz != 0) &&
- (dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_TCP_TSO) == 0) {
- fprintf(stderr,
- "Warning: TSO enabled but not supported by port %d\n",
- res->port_id);
- }
-
cmd_reconfig_device_queue(res->port_id, 1, 1);
}
--
2.33.0
More information about the dev
mailing list