[PATCH] raw/cnxk_gpio: fix resource leak

Tomasz Duszynski tduszynski at marvell.com
Tue Nov 7 10:59:46 CET 2023


Fix resource leak.

Coverity issue: 405118
Fixes: ef2a3f3b4c9e ("raw/cnxk_gpio: support multi-process")

Signed-off-by: Tomasz Duszynski <tduszynski at marvell.com>
---
 drivers/raw/cnxk_gpio/cnxk_gpio.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c
index ebc914afcf..45e2ab5e00 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.c
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c
@@ -171,8 +171,10 @@ cnxk_gpio_parse_store_args(struct cnxk_gpio_params **params, const char *args)
 		len += strlen(allowlist) + 1;
 
 	*params = cnxk_gpio_params_reserve(len);
-	if (!(*params))
-		return -ENOMEM;
+	if (!(*params)) {
+		ret = -ENOMEM;
+		goto out;
+	}
 
 	strlcpy((*params)->allowlist, allowlist, strlen(allowlist) + 1);
 
-- 
2.34.1



More information about the dev mailing list