[PATCH v3 2/5] dumpcap: allow multiple invocations

Morten Brørup mb at smartsharesystems.com
Thu Nov 9 17:00:39 CET 2023


> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Thursday, 9 November 2023 16.40
> 
> On Thu, 9 Nov 2023 08:50:10 +0100
> Morten Brørup <mb at smartsharesystems.com> wrote:
> 
> > > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> > > ---
> >
> > Minor detail: getpid() returns int, so prefer %d over %u.
> 
> Let me check, per man page. getpid() returns pid_t.
> The typedef chain leads to:
> 	pid_t -> __pid_t -> __PID_T_TYPE -> __S32_TYPE  -> int32 -> int

Thank you for confirming. So %d is preferred over %u for getpid(). :-)



More information about the dev mailing list