[PATCH v4 0/5] dumpcap and pcapng fixes
Stephen Hemminger
stephen at networkplumber.org
Thu Nov 9 18:34:07 CET 2023
This series has bugfixes and tests for dumpcap and pcapng.
It should be in 23.11!
It fixes issues related to timestamping. The design choices are
to maximize performance in the primary process; and do
all the time adjustment in the secondary (dumpcap) since
the dumpcap needs to system calls anyway to write the result.
This patches set changes where the adjustment is calculated
into the pcapng portion that opens the output file.
All details of the format of timestamp are contained inside
pcapng (data hiding).
v4 - incorporate review feedback
v3 - don't use alloca() since can have VLA type issues
Stephen Hemminger (5):
pdump: fix setting rte_errno on mp error
dumpcap: allow multiple invocations
pcapng: modify timestamp calculation
pcapng: avoid using alloca()
test: cleanups to pcapng test
app/dumpcap/main.c | 53 ++---
app/test/meson.build | 2 +-
app/test/test_pcapng.c | 418 +++++++++++++++++++++++++++-------------
lib/graph/graph_pcap.c | 2 +-
lib/pcapng/rte_pcapng.c | 156 ++++++---------
lib/pcapng/rte_pcapng.h | 19 +-
lib/pdump/rte_pdump.c | 9 +-
7 files changed, 374 insertions(+), 285 deletions(-)
--
2.39.2
More information about the dev
mailing list