[PATCH] app/testpmd: support config offloads for all ports

Ferruh Yigit ferruh.yigit at amd.com
Sat Nov 11 03:50:09 CET 2023


On 11/10/2023 9:10 AM, Dengdui Huang wrote:
> Support config Rx/Tx offload for all ports in following commands:
> 1. port config all rx_offload (offloading) (on|off)
> 2. port config all tx_offload (offloading) (on|off)
> 
> Signed-off-by: Dengdui Huang <huangdengdui at huawei.com>
> Acked-by: Chengwen Feng <fengchengwen at huawei.com>
>

Reviewed-by: Ferruh Yigit <ferruh.yigit at amd.com>

<...>

> @@ -11230,6 +11238,79 @@ static cmdline_parse_inst_t cmd_config_per_port_rx_offload = {
>  	}
>  };
>  
> +/* Enable/Disable a per port offloading */
>

Comment needs to be updated for 'all' port, and it may be good to add
Rx, like:

/* Enable/Disable all port Rx offloading */

Similar comment is for Tx code.


As this is only a minor change and rest looks good to me, I will update
while merging.



More information about the dev mailing list