[PATCH v1 1/3] net/axgbe: packet size doesn't exceed the configured MTU

Jesna K E jesna.k.e at amd.com
Sat Nov 11 17:00:04 CET 2023


Signed-off-by: Jesna K E <jesna.k.e at amd.com>
---
 drivers/net/axgbe/axgbe_ethdev.c |  6 ------
 drivers/net/axgbe/axgbe_rxtx.c   | 20 ++++++++++++++++++--
 2 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
index 3717166384..e12ee3e17a 100644
--- a/drivers/net/axgbe/axgbe_ethdev.c
+++ b/drivers/net/axgbe/axgbe_ethdev.c
@@ -1492,12 +1492,6 @@ static int axgb_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 	struct axgbe_port *pdata = dev->data->dev_private;
 	unsigned int val;
 
-	/* mtu setting is forbidden if port is start */
-	if (dev->data->dev_started) {
-		PMD_DRV_LOG(ERR, "port %d must be stopped before configuration",
-				dev->data->port_id);
-		return -EBUSY;
-	}
 	val = mtu > RTE_ETHER_MTU ? 1 : 0;
 	AXGMAC_IOWRITE_BITS(pdata, MAC_RCR, JE, val);
 
diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c
index a9ff291cef..68aa67a3fa 100644
--- a/drivers/net/axgbe/axgbe_rxtx.c
+++ b/drivers/net/axgbe/axgbe_rxtx.c
@@ -210,7 +210,7 @@ axgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
 	uint64_t old_dirty = rxq->dirty;
 	struct rte_mbuf *mbuf, *tmbuf;
 	unsigned int err, etlt;
-	uint32_t error_status;
+	uint32_t error_status, max_len;
 	uint16_t idx, pidx, pkt_len;
 
 	idx = AXGBE_GET_DESC_IDX(rxq, rxq->cur);
@@ -300,6 +300,14 @@ axgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
 					| RTE_MBUF_F_RX_IEEE1588_TMST;
 		pkt_len = AXGMAC_GET_BITS_LE(desc->write.desc3, RX_NORMAL_DESC3,
 					     PL) - rxq->crc_len;
+
+		/* Be sure we don't exceed the configured MTU */
+		max_len = rxq->pdata->eth_dev->data->mtu  + RTE_ETHER_HDR_LEN;
+			if (pkt_len > max_len) {
+				printf( "packet length exceeds configured MTU\n");
+				goto err_set;
+			}
+
 		/* Mbuf populate */
 		mbuf->next = NULL;
 		mbuf->data_off = RTE_PKTMBUF_HEADROOM;
@@ -342,7 +350,7 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue,
 	struct rte_mbuf *first_seg = NULL;
 	struct rte_mbuf *mbuf, *tmbuf;
 	unsigned int err = 0, etlt;
-	uint32_t error_status = 0;
+	uint32_t error_status = 0, max_len = 0;
 	uint16_t idx, pidx, data_len = 0, pkt_len = 0;
 	bool eop = 0;
 
@@ -409,6 +417,14 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue,
 			}
 
 		}
+
+                /* Be sure we don't exceed the configured MTU */
+                max_len = rxq->pdata->eth_dev->data->mtu  + RTE_ETHER_HDR_LEN;
+                        if (pkt_len > max_len) {
+                                printf( "packet length exceeds configured MTU\n");
+                                goto err_set;
+                        }
+
 		/* Mbuf populate */
 		mbuf->data_off = RTE_PKTMBUF_HEADROOM;
 		mbuf->data_len = data_len;
-- 
2.34.1



More information about the dev mailing list