[PATCH v2 23/43] net/af_xdp: use rte strerror
Dengdui Huang
huangdengdui at huawei.com
Tue Nov 14 12:23:47 CET 2023
The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.
Cc: stable at dpdk.org
Signed-off-by: Dengdui Huang <huangdengdui at huawei.com>
Acked-by: Chengwen Feng <fengchengwen at huawei.com>
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
index 353c8688ec..087b6e33db 100644
--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
@@ -1165,7 +1165,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,
&rxq->fq, &rxq->cq, &usr_config);
if (ret) {
AF_XDP_LOG(ERR, "Failed to create umem [%d]: [%s]\n",
- errno, strerror(errno));
+ errno, rte_strerror(errno));
goto err;
}
umem->buffer = base_addr;
@@ -1367,7 +1367,7 @@ init_uds_sock(struct sockaddr_un *server)
if (connect(sock, (struct sockaddr *)server, sizeof(struct sockaddr_un)) < 0) {
close(sock);
AF_XDP_LOG(ERR, "Error connecting stream socket errno = [%d]: [%s]\n",
- errno, strerror(errno));
+ errno, rte_strerror(errno));
return -1;
}
@@ -1451,7 +1451,7 @@ read_msg(int sock, char *response, struct sockaddr_un *s, int *fd)
return 0;
if (msglen < 0) {
- AF_XDP_LOG(ERR, "recvmsg failed, %s\n", strerror(errno));
+ AF_XDP_LOG(ERR, "recvmsg failed, %s\n", rte_strerror(errno));
return -1;
}
@@ -1486,7 +1486,7 @@ make_request_cni(int sock, struct sockaddr_un *server, char *request,
rval = send_msg(sock, request, req_fd);
if (rval < 0) {
- AF_XDP_LOG(ERR, "Write error %s\n", strerror(errno));
+ AF_XDP_LOG(ERR, "Write error %s\n", rte_strerror(errno));
return -1;
}
@@ -1970,7 +1970,7 @@ parse_prog_arg(const char *key __rte_unused,
if (access(value, F_OK) != 0) {
AF_XDP_LOG(ERR, "Error accessing %s: %s\n",
- value, strerror(errno));
+ value, rte_strerror(errno));
return -EINVAL;
}
@@ -2421,7 +2421,7 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev)
ret = rte_mp_action_register(ETH_AF_XDP_MP_KEY, afxdp_mp_send_fds);
if (ret < 0 && rte_errno != ENOTSUP) {
AF_XDP_LOG(ERR, "%s: Failed to register multi-process IPC callback: %s\n",
- name, strerror(rte_errno));
+ name, rte_strerror(rte_errno));
return -1;
}
}
--
2.33.0
More information about the dev
mailing list