[PATCH v6 2/2] dts: reformat to 100 line length

[Juraj Linkeš]

On Mon, Nov 20, 2023 at 5:50 PM Thomas Monjalon <thomas at monjalon.net> wrote:
>
> 20/11/2023 13:36, Juraj Linkeš:
> > Reformat to 100 from the previous 88 to unify with C recommendations.
> >
> > The C recommendation is the maximum with the ideal being 80. The Python
> > tools are not suitable for this flexibility.
> >
> > We require all patches with DTS code to be validated with the
> > devtools/dts-check-format.sh script, part of which is the black
> > formatting tool. We've set up black to format all of the codebase and
> > the reformat is needed so that future submitters are not affected.
> >
> > Signed-off-by: Juraj Linkeš <juraj.linkes at pantheon.tech>
> > Acked-by: Jeremy Spewock <jspewock at iol.unh.edu>
>
> In general, I don't like doing large cosmetic changes,
> but it looks mandatory to allow automatic formatting with black.
>
> Applied, thanks.
>
> Note that my pylama is still emitting warning when it goes longer than 79.
> It may be a problem in my environment but something to check.
> By the way, why are we using pylama in the script
> instead of directly calling the linters we are interested in?
>

This is a good point. It's mainly a little bit of convenience, as it's
easier to run just one tool instead of multiples (and possibly
different config files). But seeing as Pylama doesn't seem to be
maintained well (it doesn't work with mypy properly and there are
issues with pydocstyle as well), we may eschew it and go with running
the linters individually - I'll note this for the future.

>
>