[PATCH] net/mlx5: fix offset field size in conntrack action

Raslan Darawsheh rasland at nvidia.com
Tue Nov 21 16:11:05 CET 2023


Hi,
> -----Original Message-----
> From: Dariusz Sosnowski <dsosnowski at nvidia.com>
> Sent: Monday, November 20, 2023 10:25 AM
> To: Matan Azrad <matan at nvidia.com>; Slava Ovsiienko
> <viacheslavo at nvidia.com>; Ori Kam <orika at nvidia.com>; Suanming Mou
> <suanmingm at nvidia.com>
> Cc: dev at dpdk.org; Raslan Darawsheh <rasland at nvidia.com>;
> stable at dpdk.org
> Subject: [PATCH] net/mlx5: fix offset field size in conntrack action
> 
> In mlx5 PMD, struct mlx5_aso_ct_action represents a single ASO CT object
> inside a ASO CT bulk, which is used to implement conntrack flow action.
> offset field, which is 16 bits wide, in this struct represents
> an offset of the given object inside a bulk.
> 
> When SW Steering flow engine is used, ASO CT bulks are allocated on
> demand, each having 64 objects. In this case offset field can fit any
> valid object offset.
> 
> When HW Steering flow engine is used, a single ASO CT bulk is allocated
> during flow engine configuration. Since HW supports bulks bigger
> than 2^16 this offset field is too small to fit all valid values.
> This causes some ASO CT objects to be incorrectly reused on multiple
> connections, when more than 2^16 conntrack flow actions are used.
> 
> This patch fixes this behavior. offset field size is increased
> to 32 bits.
> 
> Fixes: 463170a7c934 ("net/mlx5: support connection tracking with HWS")
> Cc: suanmingm at nvidia.com
> Cc: stable at dpdk.org
> 
> Signed-off-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
> Acked-by: Ori Kam <orika at nvidia.com> 

Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh


More information about the dev mailing list