[PATCH] examples/l3fwd-power: fix to configure the uncore env

Bruce Richardson bruce.richardson at intel.com
Mon Nov 27 17:54:03 CET 2023


On Thu, Nov 23, 2023 at 02:58:58AM +0100, Thomas Monjalon wrote:
> 26/10/2023 17:19, Sivaprasad Tummala:
> > Updated the l3fwd-power app to configure the uncore env before invoking
> > any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is
> > too late because other APIs already called.
> 
> You are also updating the uncore API.
> 
> > +	if (env == RTE_UNCORE_PM_ENV_AUTO_DETECT)
> > +		/* Currently only intel_uncore is supported. This will be
> > +		 * extended with auto-detection support for multiple uncore
> > +		 * implementations.
> > +		 */
> > +		env = RTE_UNCORE_PM_ENV_INTEL_UNCORE;
> 
> It looks like this patch does not make sense without AMD support.
> 
This patch is fixing a regression introduced by an earlier patch in this
area (referenced in the fixes line). See bugzilla for more details on it[1]

This should go into 23.11 as, without it, what was working in earlier
releases no longer does so.

Thanks,
/Bruce

[1] https://bugs.dpdk.org/show_bug.cgi?id=1304


More information about the dev mailing list