[EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in checkpatch
Thomas Monjalon
thomas at monjalon.net
Tue Nov 28 16:55:08 CET 2023
28/11/2023 15:07, Ankur Dwivedi:
> >07/03/2023 13:05, Ankur Dwivedi:
> >> This patch series adds a validation in checkpatch tool to check if
> >> tracepoint is present in any new function added in ethdev, eventdev
> >> cryptodev and mempool library.
> >>
> >> v5:
> >> - Copied the build_map_changes function from check-symbol-change.sh to
> >> check-tracepoint.sh.
> >> - Added eventdev, cryptodev and mempool in libdir in check-tracepoint.sh.
> >
> >Why did you decide to copy the function in v5, instead of having a common
> >file usable by different scripts?
> >
> There was comments in v2 of the patch that common scripts may not work well and to keep the scripts specialized.
I meant you can have a common file specialized in symbols.
In general, you should reply, establish a discussion, so we share the same understanding.
More information about the dev
mailing list