[PATCH 3/3] common/cnxk: use local labels in asm intrinsic

pbhagavatula at marvell.com pbhagavatula at marvell.com
Tue Sep 5 18:39:08 CEST 2023


From: Pavan Nikhilesh <pbhagavatula at marvell.com>

Using labels in asm generates them as regular function and shades
callstack in tools like gdb or perf.
Use local label instead for better visibility.

Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
---
 drivers/common/cnxk/roc_sso_dp.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/common/cnxk/roc_sso_dp.h b/drivers/common/cnxk/roc_sso_dp.h
index 9d30286d2f..03c5bdf7ee 100644
--- a/drivers/common/cnxk/roc_sso_dp.h
+++ b/drivers/common/cnxk/roc_sso_dp.h
@@ -13,13 +13,13 @@ roc_sso_hws_head_wait(uintptr_t base)
 
 #if defined(__aarch64__)
 	asm volatile(PLT_CPU_FEATURE_PREAMBLE
-		     "		ldr %[tag], [%[tag_op]]	\n"
-		     "		tbnz %[tag], 35, done%=		\n"
+		     "		ldr %[tag], [%[tag_op]]		\n"
+		     "		tbnz %[tag], 35, .Ldone%=	\n"
 		     "		sevl				\n"
-		     "rty%=:	wfe				\n"
-		     "		ldr %[tag], [%[tag_op]]	\n"
-		     "		tbz %[tag], 35, rty%=		\n"
-		     "done%=:					\n"
+		     ".Lrty%=:	wfe				\n"
+		     "		ldr %[tag], [%[tag_op]]		\n"
+		     "		tbz %[tag], 35, .Lrty%=		\n"
+		     ".Ldone%=:					\n"
 		     : [tag] "=&r"(tag)
 		     : [tag_op] "r"(tag_op));
 #else
-- 
2.41.0



More information about the dev mailing list