[PATCH v6 7/8] net/rnp add devargs runtime parsing functions

[11]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit at amd.com>
> Sent: 2023年9月5日 23:47
> To: Wenbo Cao <caowenbo at mucse.com>
> Cc: dev at dpdk.org; thomas at monjalon.net; andrew.rybchenko at oktetlabs.ru;
> yaojun at mucse.com
> Subject: Re: [PATCH v6 7/8] net/rnp add devargs runtime parsing functions
> 
> On 9/1/2023 3:30 AM, Wenbo Cao wrote:
> > add various runtime devargs command line options supported by this
> > driver.
> >
> > Signed-off-by: Wenbo Cao <caowenbo at mucse.com>
> 
> <...>
> 
> >
> > +#define RNP_HW_MAC_LOOPBACK_ARG      "hw_loopback"
> > +#define RNP_FW_UPDATE                "fw_update"
> > +#define RNP_RX_FUNC_SELECT           "rx_func_sec"
> > +#define RNP_TX_FUNC_SELECT           "tx_func_sec"
> > +#define RNP_FW_4X10G_10G_1G_DET      "fw_4x10g_10g_1g_auto_det"
> > +#define RNP_FW_FORCE_SPEED_1G        "fw_force_1g_speed"
> > +
> 
> Please document these runtime arguments in the device document.
> 
> Also please add 'RTE_PMD_REGISTER_PARAM_STRING()' macros to document
> argument for pmdinfogen, please see samples in existing code.
> 
> <...>
> 
OK, I will check the samples.
> > +
> > +static int
> > +rnp_parse_io_select_func(const char *key, const char *value, void
> > +*extra_args) {
> > +	uint8_t select = RNP_IO_FUNC_USE_NONE;
> > +
> > +	RTE_SET_USED(key);
> > +
> > +	if (strcmp(value, "vec") == 0)
> > +		select = RNP_IO_FUNC_USE_VEC;
> > +	else if (strcmp(value, "simple") == 0)
> > +		select = RNP_IO_FUNC_USE_SIMPLE;
> > +	else if (strcmp(value, "common") == 0)
> > +		select = RNP_IO_FUNC_USE_COMMON;
> > +
> 
> There is already an generic eal argument that lets you select between vector and
> scalar datapath implementation:
> --force-max-simd-bitwidth=<val>
> 
> <...>
> 
> --force-max-simd-bitwidth=<val>
This option I have noticed before. Thanks a lot.
I will check the generic eal argume code, and reedit the interrelated code
> > +static int rnp_post_handle(struct rnp_eth_adapter *adapter) {
> > +	bool on = false;
> > +
> > +	if (!adapter->eth_dev)
> > +		return -ENOMEM;
> > +	if (adapter->do_fw_update && adapter->fw_path) {
> > +		rnp_fw_update(adapter);
> > +		adapter->do_fw_update = 0;
> 
> This patch also enables FW upgrade, can you please detail this in the commit log?
> Or even you can consider to split this part into separate patch.
> 
> 
> 
For this, I will split it to another commit.