[PATCH 08/32] net/sssnic/base: add work queue

[Renyong Wan]

Hello Stephen,

Thanks for your kindly review.

sssnic_workq is quite different from rte_ring, it's used to maintain 
information of hardware work queue, like Rx work queue, Tx work queue 
etc. Unlike rte_ring the elements of sssnic_workq are organized in a 
blcok of contiguous DMA memory accessed by hardware work queue, in 
addition the sssnic_workq records CI(consumer index) and PI(producer 
index) that synchronize with hardware work queue, driver generally 
accesses element of sssnic_workq by PI or CI.  Therefore I don't think 
rte_ring is suitable for sssnic_workq.

On 2023/9/6 23:09, Stephen Hemminger wrote:
> On Tue, 29 Aug 2023 15:58:05 +0800w
> <wanry at 3snic.com> wrote:
>
>> From: Renyong Wan <wanry at 3snic.com>
>>
>> Work queue is used to maintain hardware queue information by
>> driver, it is usually used in control queue, rx queue
>> and tx queue.
>>
>> Signed-off-by: Steven Song <steven.song at 3snic.com>
>> Signed-off-by: Renyong Wan <wanry at 3snic.com>
> Looks like this driver is reinventing rte_ring.
> Please don't do this.

-- 
Regards,
Renyong Wan