[PATCH v5 07/32] net/sssnic/base: add mailbox support

Renyong Wan wanry at 3snic.com
Mon Sep 18 07:10:27 CEST 2023


Hello Stephen,

I'll fix it next version.

On 2023/9/18 10:32, Stephen Hemminger wrote:
> On Mon, 4 Sep 2023 12:56:33 +0800
> <wanry at 3snic.com> wrote:
>
>> +struct sssnic_mbox_send_ctrl1_reg {
>> +	union {
>> +		uint32_t u32;
>> +		struct {
>> +			uint32_t resvd0 : 10;
>> +			/* Destination eventq in the mgmt cpu */
>> +			uint32_t dst_eq : 2;
>> +			/* eventq that will be informed if tx done */
>> +			uint32_t src_eq : 2;
>> +			uint32_t dma_attr : 6;
>> +			/* mailbox message size include header and body
>> +			 * must 4byte align and unit is 4byte
>> +			 */
>> +			uint32_t tx_size : 5;
>> +			uint32_t ordering : 2;
>> +			uint32_t resvd1 : 1;
>> +			/*write result back to DMA address of sending result  */
>> +			uint32_t wb : 1;
> Minor nit: the comment above has odd word spacing.

-- 
Regards,
Renyong Wan



More information about the dev mailing list