[PATCH v5 08/32] net/sssnic/base: add work queue

Renyong Wan wanry at 3snic.com
Mon Sep 18 07:11:28 CEST 2023


Hello Stephen,

  I'll fix it next version.

On 2023/9/18 10:33, Stephen Hemminger wrote:
> On Mon, 4 Sep 2023 12:56:34 +0800
> <wanry at 3snic.com> wrote:
>
>> +void *
>> +sssnic_workq_consume(struct sssnic_workq *workq, uint16_t num_entries,
>> +	uint16_t *ci)
>> +{
>> +	void *e;
>> +	uint16_t current_ci;
>> +
>> +	if (workq->idle_entries + num_entries > workq->num_entries)
>> +		return NULL;
>> +
>> +	current_ci = sssnic_workq_ci_get(workq);
>> +	e = (void *)sssnic_workq_entry_get(workq, current_ci);
> Minor nit: cast to void * is not normally necessary in C.
> Compiler will do it for you.

-- 
Regards,
Renyong Wan



More information about the dev mailing list