[EXT] Re: [PATCH v1 02/34] ml/cnxk: drop use of RTE API for firmware read

[David Marchand]

On Thu, Sep 21, 2023 at 3:06 PM Srikanth Yalavarthi
<syalavarthi at marvell.com> wrote:
> > > > archive. This causes the ML firmware binary to be parsed
> > > > incorrectly.
> > >
> > > + @David Marchand  rte_firmware_read() author for his opinions
> >
> > /lib/firmware/mlip-fw.bin does not seem to be something packaged in
> > Fedora, and I found no trace in linux-firmware repo, so I can't reproduce
> > your issue.
> >
> > Please add some debug and give more details about the issue you are facing.
>
> The "/lib/firmware/mlip-fw.bin" is Marvell's ML firmware binary. This file is in un-compressed form.
>
> When DPDK is built without libarchive support, No issues are observed with using  rte_firmware_read to load the firmware file as open and read system calls are used.
>
> When libarchive support is enabled, rte_firmware_read tries to parse the firmware binary as an xz archive. Since the file is not an archive, this step is failing.

Please debug this part and point at the exact place where it fails.

>
> Hence, added new ML driver function to read the firmware binary.

This is just avoiding the issue without understanding it...


-- 
David Marchand