[PATCH v4 4/7] app/proc-info: fix never show RSS info

[Jie Hai]

On 2023/9/13 19:48, Pattan, Reshma wrote:
> 
> 
>> -----Original Message-----
>> From: Jie Hai <haijie1 at huawei.com>
>> Sent: Friday, September 8, 2023 9:00 AM
>> To: dev at dpdk.org; Pattan, Reshma <reshma.pattan at intel.com>; Vipin
>> Varghese <vipin.varghese at amd.com>; Mcnamara, John
>> <john.mcnamara at intel.com>
>> Cc: haijie1 at huawei.com; lihuisong at huawei.com
>> Subject: [PATCH v4 4/7] app/proc-info: fix never show RSS info
>>
>> Command show-port should show RSS info (rss_key, len and rss_hf), However,
>> the information is shown only when rss_conf.rss_key is not NULL. Since no
>> memory is allocated for rss_conf.rss_key, rss_key will always be NULL and the
>> rss_info will never show. This patch allocates memory for rss_conf.rss_key and
>> makes it possible to show RSS info.
>>
> 
Hi, Pattan, Reshma
> Nitpick:
> You have to change the commit message as malloc and free not used now.
> 
> Acked-by: Reshma Pattan <reshma.pattan at intel.com>
> 
> 
Thanks for your comment, will do in next version.

Best regards,
Jie Hai
> 
> 
> .